-
Notifications
You must be signed in to change notification settings - Fork 347
Proposal - Add EVM (emacs version manager) to deal with emacs versions on travis #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal - Add EVM (emacs version manager) to deal with emacs versions on travis #373
Conversation
c843a98
to
280cec5
Compare
b7ca1dc
to
1ebd0d4
Compare
12b8c20
to
3e14f31
Compare
3e14f31
to
0f4bd9f
Compare
@ardumont: I have a bit of trouble following what you did here. There are 5 commits, most of them seem to unrealed to EVM... Can you somehow explain what is going on? |
Hello,
It's difficult to follow because it's now out of context.
I proposed in order 3 PR with separate concerns (but depending on each other):
This PR has been closed but the main functionality has been merged by @chrisdone (via cherry-picking) because it was on a major refactoring on the side. I believe the tests have not been integrated.
I believe that this can:
Does this make better sense to you? Cheers, |
I remembered right, the tests have not been merged: #370 (comment) |
@purcell: I refer to you as my Emacs knowledge is not good enough to see what is needed here. |
It's installed here 0f4bd9f#diff-354f30a63fb0907d4ad57269548329e3R21 (Oh and I need to update this PR if you are still interested by this.) |
Keep only the targets which work. Is this ok? Conflicts: .travis.yml
0f4bd9f
to
96ffdc2
Compare
Just rebased this PR with latest code. To keep up with what I just said @purcell, this https://github.com/haskell/haskell-mode/pull/373/files#diff-354f30a63fb0907d4ad57269548329e3R21 is what installs evm. |
Yes, thanks. #477 is now applied. |
Again, it's a proposal (this eases the .travis.yml's readability).
Also, this reduces the use of Damien Cassou's PPA which is no longer
maintained.
What are the targeted versions for emacs?
At the moment, it's ok with emacs-24.3 and emacs-24.4 but otherwise, there are limitations:
Cheers,