Skip to content

Proposal - Add EVM (emacs version manager) to deal with emacs versions on travis #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ardumont
Copy link
Contributor

Again, it's a proposal (this eases the .travis.yml's readability).

Also, this reduces the use of Damien Cassou's PPA which is no longer
maintained
.

What are the targeted versions for emacs?

At the moment, it's ok with emacs-24.3 and emacs-24.4 but otherwise, there are limitations:

  • emacs-23.4 -> limit from cask not supporting before emacs 24
  • emacs 24.1 -> pb in ghc-core.el regarding cl-lib
  • emacs 24.2 -> the same

Cheers,

@ardumont ardumont force-pushed the use-evm-for-emacs-install-purposes branch 7 times, most recently from c843a98 to 280cec5 Compare November 11, 2014 13:26
@ardumont ardumont changed the title Tryout - Add EVM (emacs version manager) to deal with emacs versions on travis Add EVM (emacs version manager) to deal with emacs versions on travis Nov 11, 2014
@ardumont ardumont force-pushed the use-evm-for-emacs-install-purposes branch 4 times, most recently from b7ca1dc to 1ebd0d4 Compare November 11, 2014 14:19
@ardumont ardumont changed the title Add EVM (emacs version manager) to deal with emacs versions on travis Proposal - Add EVM (emacs version manager) to deal with emacs versions on travis Nov 11, 2014
@ardumont ardumont force-pushed the use-evm-for-emacs-install-purposes branch 2 times, most recently from 12b8c20 to 3e14f31 Compare November 16, 2014 15:43
@ardumont ardumont force-pushed the use-evm-for-emacs-install-purposes branch from 3e14f31 to 0f4bd9f Compare November 20, 2014 20:16
@gracjan
Copy link
Contributor

gracjan commented Feb 17, 2015

@ardumont: I have a bit of trouble following what you did here. There are 5 commits, most of them seem to unrealed to EVM... Can you somehow explain what is going on?

@ardumont
Copy link
Contributor Author

Hello,

@ardumont: I have a bit of trouble following what you did here. There are 5 commits, most of them seem to unrealed to EVM...

It's difficult to follow because it's now out of context.

Can you somehow explain what is going on?

I proposed in order 3 PR with separate concerns (but depending on each other):

  • Proposal - Add haskell-process-wrapper-function #370 to permit the use of haskell-process-wrapper-function (use of nix-shell, docker, ...).
    This introduced some unit tests because I wanted to be certain not to break this awesome mode.
    But for this, I add to make 1 quick hack to permit the triggering of tests.

This PR has been closed but the main functionality has been merged by @chrisdone (via cherry-picking) because it was on a major refactoring on the side.

I believe the tests have not been integrated.

I believe that this can:

  • either be closed if haskell-mode maintainers are not interested by this.
  • either you are interested, thus, I need to rebase the code, remove the needless commits and see what's wrong.

Does this make better sense to you?

Cheers,

@ardumont
Copy link
Contributor Author

I remembered right, the tests have not been merged: #370 (comment)

@gracjan
Copy link
Contributor

gracjan commented Feb 27, 2015

@purcell: I refer to you as my Emacs knowledge is not good enough to see what is needed here.

@purcell
Copy link
Member

purcell commented Feb 27, 2015

@ardumont Where does ~/.evm come from? 0f4bd9f adds references to it, but I don't understand how that all comes together.

@ardumont
Copy link
Contributor Author

@ardumont Where does ~/.evm come from? 0f4bd9f adds references to it, but I don't understand how that all comes together.

It's installed here 0f4bd9f#diff-354f30a63fb0907d4ad57269548329e3R21

(Oh and I need to update this PR if you are still interested by this.)

Keep only the targets which work.
Is this ok?

Conflicts:
	.travis.yml
@ardumont ardumont force-pushed the use-evm-for-emacs-install-purposes branch from 0f4bd9f to 96ffdc2 Compare February 28, 2015 09:06
@ardumont
Copy link
Contributor Author

Just rebased this PR with latest code.

To keep up with what I just said @purcell, this https://github.com/haskell/haskell-mode/pull/373/files#diff-354f30a63fb0907d4ad57269548329e3R21 is what installs evm.

@ardumont
Copy link
Contributor Author

@gracjan's PR #477 seems to do the same with less limitations than this one.

@purcell I think we can close this one, what do you think?

@purcell purcell closed this Feb 28, 2015
@purcell
Copy link
Member

purcell commented Feb 28, 2015

Yes, thanks. #477 is now applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants