Skip to content

Jump to next/previous prompt in haskell-interactive-mode #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2015

Conversation

markus1189
Copy link
Contributor

New functions:

  • haskell-interactive-mode-next-prompt
  • haskell-interactive-mode-prev-prompt

New keybindings in haskell-interactive-mode-map:

  • C-c C-n jump to next prompt
  • C-c C-p jump to previous prompt

24pullrequests

Best,
Markus

@purcell
Copy link
Member

purcell commented Jan 17, 2015

Thanks. Could you rename them to

    haskell-interactive-mode-prompt-next
    haskell-interactive-mode-prompt-previous

to match the convention of the -history-next and -history-previous commands? Also, the (interactive "") in the second command should presumably just be (interactive) like in the first.

@purcell
Copy link
Member

purcell commented Jan 17, 2015

(If you amend the commit and force-push it, it will keep the commit history clean.)

New functions:

- `haskell-interactive-mode-next-prompt`
- `haskell-interactive-mode-prev-prompt`

New keybindings in `haskell-interactive-mode-map`:

- `C-c C-n` jump to next prompt
- `C-c C-p` jump to previous prompt
@markus1189
Copy link
Contributor Author

Sure. Btw, thanks for taking the time to work through the pull requests.

@purcell
Copy link
Member

purcell commented Jan 17, 2015

Great, merging now. Thanks.

purcell added a commit that referenced this pull request Jan 17, 2015
Jump to next/previous prompt in haskell-interactive-mode
@purcell purcell merged commit 12da44f into haskell:master Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants