Expose "format" function in Sylish.hs #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's going to be needed for the haskell-ide integration
jaspervdj
approved these changes
Jan 26, 2020
jaspervdj
reviewed
Jan 26, 2020
EncodePanda
approved these changes
Jan 26, 2020
| @@ -91,3 +93,13 @@ runStep exts mfp ls step = | |||
| runSteps :: Extensions -> Maybe FilePath -> [Step] -> Lines | |||
| -> Either String Lines | |||
| runSteps exts mfp steps ls = foldM (runStep exts mfp) ls steps | |||
|
|
|||
| newtype ConfigPath = ConfigPath { unConfigPath :: FilePath } | |||
There was a problem hiding this comment.
I love the newtype added. Type safety for the win :)
| , testCase "case 02" case02 | ||
| , testCase "case 03" case03 | ||
| ] | ||
|
|
There was a problem hiding this comment.
remove those two empty lines maybe?
Co-Authored-By: Jasper Van der Jeugt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's going to be needed for the haskell-ide integration