HHH-14478 : Allow DialectResolvers to be discovered by ServiceLoader #3792
Conversation
- - Note : the changes to `org.hibernate.dialect.resolver.DialectFactoryTest` were needed to make them pass. However, the failures were not caused by changes done in this work. They mostly likely "broke" when the initial Dialect clean up work was done. This test was part of the "filtered out" tests in terms of the Gradle build, so they would not show up on CI runs e.g. after those earlier changes - Note 2 : at least locally, the test `org.hibernate.test.annotations.derivedidentities.bidirectional.OneToOneWithDerivedIdentityTest` is failing the build even though it is outside of the filtered include package. No idea why that test gets picked up; nor why it just started now..
| public void addResolverAtFirst(DialectResolver... resolvers) { | ||
| // in reverse so that the first item in the incoming list is added | ||
| // to the first position in `this.resolutions` | ||
| for ( int i = resolvers.length - 1; i >= 0; i-- ) { |
There was a problem hiding this comment.
Minor, but could be done by using this.resolvers.addAll( 0, Arrays.asList( resolvers ) );
I just fixed that. After a rebase this should be fine. |
curiosity sake... what was the issue? |
Co-authored-by: Christian Beikov <[email protected]>
|
Squashed, rebased and applied upstream |
|
Excellent! |
|
@sebersole actually |
HHH-14478 : Allow DialectResolvers to be discovered by ServiceLoader
Note : the changes to
org.hibernate.dialect.resolver.DialectFactoryTestwere needed to make them pass. However, the failures were not caused by changes done in this work. They mostly likely "broke" when the initial Dialect clean up work was done. This test was part of the "filtered out" tests in terms of the Gradle build, so they would not show up on CI runs e.g. after those earlier changesNote 2 : at least locally, the test
org.hibernate.test.annotations.derivedidentities.bidirectional.OneToOneWithDerivedIdentityTestis failing the build even though it is outside of the filtered include package. No idea why that test gets picked up; nor why it just started now..