HHH-16125 PostgreSQL enum types + reimplementation of enum support #6448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -36,32 +36,46 @@ | |||
| */ | |||
| int getSqlTypeCode(); | |||
|
|
|||
| default String getTypeName(Size columnSize, Class<?> returnedClass) { | |||
| return getTypeName( columnSize ); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
gavinking
changed the title
|
|
||
| try ( SessionFactoryImplementor sf = (SessionFactoryImplementor) metadata.buildSessionFactory() ) { | ||
| EntityPersister p = sf.getRuntimeMetamodels() | ||
| .getMappingMetamodel() | ||
| .getEntityDescriptor( AddressLevel.class.getName() ); | ||
| //noinspection unchecked | ||
| ConvertedBasicType<Nature> runtimeType = (ConvertedBasicType<Nature>) p.getPropertyType( "nature" ); | ||
| assertEquals( Types.VARCHAR, runtimeType.getJdbcType().getJdbcTypeCode() ); | ||
| BasicType<Nature> runtimeType = (BasicType<Nature>) p.getPropertyType( "nature" ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| throw new HibernateException("Enum class not found: " + enumClassName, exception); | ||
| } | ||
| } else { | ||
| enumClass = (Class<T>) reader.getReturnedClass().asSubclass(Enum.class); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
gavinking
force-pushed
the
16125
branch
2 times, most recently
from
00ef478 to
b0f447e
Compare
| @@ -167,8 +165,7 @@ | |||
|
|
|||
| @Incubating | |||
| default String getSpecializedTypeDeclaration(Dialect dialect) { | |||
| final BasicValueConverter<T, ?> valueConverter = getValueConverter(); | |||
| return valueConverter == null ? null : valueConverter.getSpecializedTypeDeclaration( getJdbcType(), dialect ); | |||
| return getMappedJavaType().getSpecializedTypeDeclaration( getJdbcType(), getValueConverter(), dialect ); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
gavinking
force-pushed
the
16125
branch
6 times, most recently
from
305850d to
0c6d089
Compare
incl attempt to fix PK to FK copying
this is probably a pre-existing hole in the logic, not related really related to my work
- introduce SqlTypes.ENUM - no more converters! - finish of Potgres enum support - disable BIND for enums in Criteria on PostgreSQL (PostgreSQL doesn't do the needed type conversion to the enum type)
it never belonged there!
fixes allowing correct serialization/deserialization of enums includes workaround for StructJdbcType sending us a BigDecimal (need better solution)
…ion details these are bad tests; they don't test observable behavior
|
Superseded by #6480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try was #6232.
This time things went somewhat more smoothly, except that I ran into a problem with enum types in foreign keys.
I'm now concerned that we'll have to abandon the whole
specialiedTypeDeclarationthing I added to let converters have a vote on the generated DDL types. In place of that I would probably introduceSqlTypes.ENUMand pass the enum type along with theSizeclass. So there would be a realDdlTypefor native enums.