HHH-18532 Date/time related JavaType's are not always properly unwrapping into java.util.Date subclasses #8833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbladel
reviewed
Aug 28, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/JdbcTimestampJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ZonedDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
...te-core/src/test/java/org/hibernate/orm/test/mapping/type/java/DateSubclassesUnwrapTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
mbladel
reviewed
Aug 28, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ZonedDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
cigaly
force-pushed
the
HHH-18532
branch
2 times, most recently
from
02fff14 to
a7f1c0d
Compare
gavinking
reviewed
Sep 19, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Sep 19, 2024
hibernate-core/src/main/java/org/hibernate/type/descriptor/java/OffsetDateTimeJavaType.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Sep 19, 2024
cigaly
force-pushed
the
HHH-18532
branch
2 times, most recently
from
11fecb6 to
e5a3870
Compare
cigaly
force-pushed
the
HHH-18532
branch
2 times, most recently
from
1f7511d to
ffaaaee
Compare
Co-authored-by: Marco Belladelli <[email protected]>
- reordered matching in unwrap methods to push java.util.Date after java.sql.{Date,Time,Timestamp}
- use new java.sql.{Date,Time}(instant.toEpochMilli()) instead of java.sql.{Date,Time}.from(instant);
later method is not subclasses so it is always returning instance of java.util.Date
mbladel
reviewed
Apr 28, 2025
Comment on lines
+68
to
+70
| final LocalTime localTime = Instant.ofEpochMilli( millis ).atZone( ZoneId.systemDefault() ).toLocalTime(); | ||
| final Time time = Time.valueOf( localTime ); | ||
| time.setTime( time.getTime() + localTime.getNano() / 1_000_000 ); |
There was a problem hiding this comment.
Is it always correct to assume the provided epoch value is in the ZoneId.systemDefault() time zone? I'm afraid this might cause problems. Also having to restore milliseconds using getNano() is unfortunate.
I would much rather prefer an implementation similar to JdbcDateJavaType#toDateEpoch, e.g. toTimeEpoch that instead sets the YEAR, MONTH and DATE to 1970-01-01 and derives the correct time-only milliseconds value from that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira issue HHH-18532
Fixing unwrapping date/time related values into
java.sql.Dateandjava.sql.TimeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.