Skip to content

Use UPDATE event type for generator where applicable #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

marko-bekhta
Copy link
Member

fixes #2138

I've added the test as disabled, as we'd need an ORM release that fixes https://hibernate.atlassian.net/browse/HHH-19306 first

@DavideD DavideD changed the title [#2138] Use UPDATE event type for generator where applicable Use UPDATE event type for generator where applicable Apr 1, 2025
@DavideD
Copy link
Member

DavideD commented Apr 7, 2025

Thanks for the PR, but does it make sense to merge this without the fix for ORM?
I don't see any benefit, I think I would prefer to have the test enabled and then apply this fix after the next ORM release.

@marko-bekhta
Copy link
Member Author

yeah... that would be best to wait for the ORM fix and then apply this patch... I did want to run the CI build against all DBs (was only testing postgres locally) to make sure it doesn't break something else 😃

@DavideD
Copy link
Member

DavideD commented Apr 7, 2025

Make sense, but the fix looks simple enough that I don't expect problems with the other databases (finger crossed).
And even if it does, it shouldn't be too hard to fix (or we can fix it as a separate issue).

You've already done the hard part 😃
(figuring out the issue and propose a solution)

I'm more worried about merging this and forgetting to reenable the test.

@DavideD DavideD added the waiting We are waiting for another PR or issue to be solved before merging this one label Apr 7, 2025
@DavideD
Copy link
Member

DavideD commented Apr 7, 2025

@marko-bekhta Now that https://hibernate.atlassian.net/browse/HHH-19306 has been merged, you can rebase this PR on top of wip/3.0 and it will test correctly as soon as the ORM snapshot has been released.

@marko-bekhta marko-bekhta force-pushed the fix/i2138-generator-event-type branch from e544f97 to e80d390 Compare April 7, 2025 22:01
@marko-bekhta marko-bekhta changed the base branch from main to wip/3.0 April 7, 2025 22:01
@marko-bekhta
Copy link
Member Author

👍🏻 rebased and changed the patch for wip/3.0.
I'm thinking since we have that fix for 6.6 too (hibernate/hibernate-orm#9946), maybe we want to backport to 2.4 so we could bump it in Quarkus?

@DavideD
Copy link
Member

DavideD commented Apr 8, 2025

I will backport it, thanks

@DavideD DavideD modified the milestone: 3.0.0.CR1 Apr 8, 2025
@DavideD DavideD force-pushed the wip/3.0 branch 2 times, most recently from 9f742da to c1e06b9 Compare April 15, 2025 18:46
@marko-bekhta marko-bekhta force-pushed the fix/i2138-generator-event-type branch from e80d390 to a3ff7a2 Compare April 18, 2025 12:10
@DavideD
Copy link
Member

DavideD commented Apr 25, 2025

@marko-bekhta Could you rebase this on top of main, please? We can merge it now

@marko-bekhta marko-bekhta force-pushed the fix/i2138-generator-event-type branch from a3ff7a2 to fd49837 Compare April 25, 2025 15:37
@marko-bekhta marko-bekhta changed the base branch from wip/3.0 to main April 25, 2025 15:39
@marko-bekhta marko-bekhta force-pushed the fix/i2138-generator-event-type branch from fd49837 to c22bfa0 Compare April 25, 2025 15:41
@marko-bekhta marko-bekhta reopened this Apr 25, 2025
@marko-bekhta
Copy link
Member Author

changing the base branch in PR makes GH do strange things 😄, but looks like tests are running now 🤞🏻

@DavideD
Copy link
Member

DavideD commented Apr 25, 2025

Thanks @marko-bekhta, perfect!

@DavideD DavideD merged commit 5029fc9 into hibernate:main Apr 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs ORM core release waiting We are waiting for another PR or issue to be solved before merging this one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating an entity updates the creation timestamp (and the update timestamp)
2 participants