-
Notifications
You must be signed in to change notification settings - Fork 95
Use UPDATE event type for generator where applicable #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UPDATE event type for generator where applicable #2172
Conversation
Thanks for the PR, but does it make sense to merge this without the fix for ORM? |
yeah... that would be best to wait for the ORM fix and then apply this patch... I did want to run the CI build against all DBs (was only testing postgres locally) to make sure it doesn't break something else 😃 |
Make sense, but the fix looks simple enough that I don't expect problems with the other databases (finger crossed). You've already done the hard part 😃 I'm more worried about merging this and forgetting to reenable the test. |
@marko-bekhta Now that https://hibernate.atlassian.net/browse/HHH-19306 has been merged, you can rebase this PR on top of |
e544f97
to
e80d390
Compare
👍🏻 rebased and changed the patch for wip/3.0. |
I will backport it, thanks |
9f742da
to
c1e06b9
Compare
e80d390
to
a3ff7a2
Compare
@marko-bekhta Could you rebase this on top of main, please? We can merge it now |
a3ff7a2
to
fd49837
Compare
fd49837
to
c22bfa0
Compare
changing the base branch in PR makes GH do strange things 😄, but looks like tests are running now 🤞🏻 |
Thanks @marko-bekhta, perfect! |
fixes #2138
I've added the test as disabled, as we'd need an ORM release that fixes https://hibernate.atlassian.net/browse/HHH-19306 first