Fix dead reference to non-existing template repository #4267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
May 28, 2025
| @@ -10,7 +10,7 @@ So you'd like to create and share your own language definition for Highlight.js. | |||
| - [ ] Clone the main [highlight-js](https://github.com/highlightjs/highlight.js) repository from GitHub | |||
| - [ ] Read our [Language Contributor Checklist](https://highlightjs.readthedocs.io/en/latest/language-contribution.html) | |||
| - [ ] Review the [Language Definition Guide](https://highlightjs.readthedocs.io/en/latest/language-guide.html) | |||
| - [ ] Start with our [repository template](https://github.com/highlightjs/highlightjs-language-template) to more easily follow the suggested layout. (this isn't ready yet!) | |||
| - [ ] Start with our [repository template](https://github.com/sebastiaanspeck/highlightjs-language-template) to more easily follow the suggested layout. (this isn't ready yet!) | |||
There was a problem hiding this comment.
Do you consider yours "ready"? If so perhaps we change this to something more like:
- [ ] You might find Sebastian Speck's [repository template] helpful as a starting point.
Or some such. Thoughts?
There was a problem hiding this comment.
It is a amalgamation of the template repository from https://github.com/jf990/highlightjs-language-template (which is 4 years old and not up-to-date), and my highlightjs-magik (which e.g. uses mocha instead of jasmine). I am also willing to hand-over my repository to your organisation, so the dead-link will work again.
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +3 B View Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3038
Changes
Added a link to an up-to-date and working template repository. Feel free to migrate my template repository to highlight.js organisation.
Checklist
CHANGES.md, doesn't apply here because nothing really changed