GitAuto: makeBrowserOfflineTransport no longer adds types to transportOptions #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Why the bug occurs
The bug occurs because the
makeBrowserOfflineTransport
function no longer adds the necessary types totransportOptions
, leading to a TypeScript error when using options likeflushAtStartup
that are not recognized in the current type definition ofBrowserTransportOptions
.How to reproduce
makeBrowserOfflineTransport
function withtransportOptions
that include properties not defined inBrowserTransportOptions
.How to fix
To fix this issue, we need to update the type definitions for
BrowserTransportOptions
to include the additional properties that are valid when usingmakeBrowserOfflineTransport
. Specifically, we should:transportOptions
when usingmakeBrowserOfflineTransport
.BrowserTransportOptions
to include these properties, ensuring that TypeScript recognizes them as valid.Test these changes locally