GitAuto: makeBrowserOfflineTransport no longer adds types to transportOptions #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Why the bug occurs
In version 8.33.1 of the Sentry SDK,
makeBrowserOfflineTransport
no longer includes the necessary type definitions fortransportOptions
. As a result, properties likeflushAtStartup
are not recognized by TypeScript, leading to type errors when initializing Sentry with these options.How to reproduce
makeBrowserOfflineTransport
withtransportOptions
that includeflushAtStartup
.How to fix
Update the type definitions for
makeBrowserOfflineTransport
to include theflushAtStartup
property withintransportOptions
. This involves modifying the TypeScript interfaces in the Sentry SDK to recognize and allowflushAtStartup
as a valid option. Ensuring thatBrowserTransportOptions
extends to accommodate custom properties will resolve the TypeScript error and eliminate the need for manual type assertions.Test these changes locally