Re-enable codecov #364
Re-enable codecov #364
Conversation
|
(Once CI finishes; I'll rebase to pull in the other CI patch) |
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=========================================
Coverage ? 90.78%
=========================================
Files ? 50
Lines ? 6927
Branches ? 1322
=========================================
Hits ? 6289
Misses ? 482
Partials ? 156Continue to review full report at Codecov.
|
|
#365 should be merged first, as that makes this one a bit easier. |
|
I'll take a look at this tomorrow. Thank you! |
| optional: -r{toxinidir}/requirements-optional.txt | ||
| -r{toxinidir}/requirements-test.txt | ||
| doc: Sphinx |
There was a problem hiding this comment.
It looks like when this ran the tests with six==1.9, it'd also run the tests with the optional requirements. I'm pretty sure your changes don't do that--six19 is a separate environment from optional.
I don't know offhand if that's important, but it seems like if we want to maintain parity, it'd be better to add a line here like:
six19: -r{toxinidir}/requirements-optional.txt
There was a problem hiding this comment.
Sorry, yes I missed that. It would be better to achieve that by using TOXENV=six19-optional .
| commands = | ||
| {envbindir}/py.test {posargs} | ||
| six19: pip install six==1.9 | ||
| {env:PYTEST_COMMAND:{envbindir}/py.test} {posargs} | ||
| flake8 {toxinidir} |
There was a problem hiding this comment.
In other projects I work on, I run flake8 as a separate environment because there isn't much reason to run it multiple times. Having said that, it seems like it only takes a few seconds on html5lib-python, so seems like it'd not a big deal here.
There was a problem hiding this comment.
flake8 could be moved out to a separate factor easily, and even a different testenv.
It is important to run flake8 on each version of python, as pyflakes is version dependent.
The benefit of keeping it in here is that devs dont need to remember to do it, and they typically only test on one environment. For CI, the running time is inconsequential compared to the rest of the very voluminous tests ;-)
There was a problem hiding this comment.
+1 to everything you say here. Don't change what you have.
|
@jayvdb Are you still working on this or are you done? |
|
You've found one thing that needs fixing, and I'm happy to change the flake8 invocation also. |
The use of `coverage combine` without multiple sets of data has been resulting in a warning `No data to combine` and the data not being submitted.
Coverage of PyPy was disabled however it works without trouble, albeit a little slow. To allow tox to run tests under coverage, and with arguments passed to coverage, PYTEST_COMMAND can now be used to override the default command used to run the tests. Due to pips inability to deal with multiple requirements for the same package, six==1.9 is forcably installed after the tox environment has been setup.
|
2.2.5 , or 3.2.5? |
|
Bleh. I'm having typing problems today. I meant 3.2.5. Thanks! |
|
I have cherry-picked your commit; I hope that is OK. |
|
You rock--thank you! |
This also removes dependence on
./requirements-install.shandflake8-run.sh