-
Notifications
You must be signed in to change notification settings - Fork 294
Remove last note about nose #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is very cosmetic. Given the content and location of the file, part of me thinks we should remove it altogether. @gsnedders @jgraham Can one of you review this, please? |
I'd also be totally happy with removing it, honestly. Merge this if you want, or just delete it. |
I'll change this PR to remove that file. Thank you! |
This file wasn't informative enough beyond existing documentation. Best to remove it.
@gsnedders I rebased on master tip to pick up the pytest fixes so that CI would pass. That caused the previous reviews to become stale, so this needs another review. Sorry about that! |
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 50 50
Lines 6927 6927
Branches 1322 1322
=======================================
Hits 6289 6289
Misses 482 482
Partials 156 156 Continue to review full report at Codecov.
|
Thank you! |
This nixes the last bit about nose re: issue #182.