Skip to content

Remove last note about nose #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Remove last note about nose #366

merged 2 commits into from
Nov 29, 2017

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Nov 27, 2017

This nixes the last bit about nose re: issue #182.

@willkg willkg added this to the 1.0 milestone Nov 27, 2017
@willkg
Copy link
Contributor Author

willkg commented Nov 27, 2017

This is very cosmetic. Given the content and location of the file, part of me thinks we should remove it altogether.

@gsnedders @jgraham Can one of you review this, please?

gsnedders
gsnedders previously approved these changes Nov 28, 2017
@gsnedders
Copy link
Member

gsnedders commented Nov 28, 2017

I'd also be totally happy with removing it, honestly. Merge this if you want, or just delete it.

@willkg
Copy link
Contributor Author

willkg commented Nov 28, 2017

I'll change this PR to remove that file. Thank you!

gsnedders
gsnedders previously approved these changes Nov 28, 2017
This file wasn't informative enough beyond existing documentation. Best
to remove it.
@willkg
Copy link
Contributor Author

willkg commented Nov 29, 2017

@gsnedders I rebased on master tip to pick up the pytest fixes so that CI would pass. That caused the previous reviews to become stale, so this needs another review. Sorry about that!

@codecov-io
Copy link

codecov-io commented Nov 29, 2017

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          50       50           
  Lines        6927     6927           
  Branches     1322     1322           
=======================================
  Hits         6289     6289           
  Misses        482      482           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b515f5...b075384. Read the comment docs.

@gsnedders gsnedders merged commit b105f6e into html5lib:master Nov 29, 2017
@willkg
Copy link
Contributor Author

willkg commented Nov 29, 2017

Thank you!

@willkg willkg deleted the 182-nix-nose branch November 29, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants