Skip to content

Allow uppercase hex chararcters in CSS colour check #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2017
Merged

Allow uppercase hex chararcters in CSS colour check #377

merged 3 commits into from
Nov 30, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Nov 30, 2017

Fixes #354.

@willkg willkg added this to the 1.0 milestone Nov 30, 2017
@willkg
Copy link
Contributor

willkg commented Nov 30, 2017

This is awesome work! As soon as all the CI things are green, I'll merge this. Thank you!

@codecov-io
Copy link

Codecov Report

Merging #377 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   90.78%   90.76%   -0.03%     
==========================================
  Files          50       50              
  Lines        6927     6950      +23     
  Branches     1322     1328       +6     
==========================================
+ Hits         6289     6308      +19     
- Misses        482      483       +1     
- Partials      156      159       +3
Impacted Files Coverage Δ
html5lib/filters/sanitizer.py 93.16% <ø> (ø) ⬆️
html5lib/tests/test_sanitizer.py 94.59% <100%> (+0.65%) ⬆️
html5lib/treebuilders/__init__.py 81.81% <0%> (-18.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d595d0a...a5a1900. Read the comment docs.

@willkg willkg merged commit c4a85fc into html5lib:master Nov 30, 2017
@willkg
Copy link
Contributor

willkg commented Nov 30, 2017

Thank you!

@hugovk hugovk deleted the upper-hex-in-css-colour branch November 30, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants