Skip to content

Travis CI: Add Python 3.7 and pypy3 #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 18, 2019
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 18, 2019

Python 3.4 is End of Life: https://devguide.python.org/devcycle/#end-of-life-branches

Travis are now recommending removing the sudo tag.

"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"

Conditionally install datrie only if on CPython < 3.7 as a workaround to pytries/datrie#52 which although closed is not yet released to https://pypi.org/project/datrie as discussed in pytries/datrie#68. It would also be possible to add pip3 install git+https://github.com/pytries/datrie.git on CPython >= 3.7.

cclauss added 3 commits April 18, 2019 07:04
Python 3.4 is End of Life: https://devguide.python.org/devcycle/#end-of-life-branches

[Travis are now recommending removing the __sudo__ tag](https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration).

"_If you currently specify __sudo: false__ in your __.travis.yml__, we recommend removing that configuration_"
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          50       50           
  Lines        6952     6952           
  Branches     1328     1328           
=======================================
  Hits         6312     6312           
  Misses        481      481           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a3449...af919af. Read the comment docs.

@gsnedders
Copy link
Member

FWIW: given we're a vendored dependency of pip, we've typically avoided dropping support for any version of Python still supported by pip, which implies we should still support Py3.4.

@cclauss cclauss changed the title Travis CI: Add Python 3.7 and remove Python 3.4 Travis CI: Add Python 3.7 and pypy3 Apr 18, 2019
@gsnedders gsnedders merged commit 2d8919a into html5lib:master Apr 18, 2019
@gsnedders
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants