Skip to content

Drop support for EOL Python 3.4 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Drop support for EOL Python 3.4 #421

merged 1 commit into from
Oct 29, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 5, 2019

Python 3.4 is EOL since 2019-03-16 and no longer receiving security updates (or any updates) from the core Python team.

This allows 5 jobs to be removed from the build (3 Travis, 2 AppVeyor), and allows the project to concentrate on supported Python versions.

This PR also adds python_requires to help pip install the correct package version for their running Python.

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          50       50           
  Lines        6952     6952           
  Branches     1328     1328           
=======================================
  Hits         6312     6312           
  Misses        481      481           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b22754...115379d. Read the comment docs.

@jgraham jgraham merged commit 77879b0 into html5lib:master Oct 29, 2019
@gsnedders
Copy link
Member

pypa/pip@2c1010e dropped support for 3.4 in pip, shipped in 19.2.

@hugovk hugovk deleted the rm-3.4 branch October 30, 2019 03:55
@hugovk hugovk mentioned this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants