Skip to content

Update flake8 to the latest version and fix all errors #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Update flake8 to the latest version and fix all errors #428

merged 2 commits into from
Feb 26, 2020

Conversation

jdufresne
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #428 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   90.52%   90.57%   +0.05%     
==========================================
  Files          50       50              
  Lines        6973     6968       -5     
  Branches     1328     1328              
==========================================
- Hits         6312     6311       -1     
+ Misses        502      498       -4     
  Partials      159      159
Impacted Files Coverage Δ
html5lib/tests/tokenizertotree.py 0% <ø> (ø) ⬆️
html5lib/tests/support.py 92.24% <ø> (ø) ⬆️
html5lib/treewalkers/etree.py 86.07% <ø> (ø) ⬆️
html5lib/tests/tree_construction.py 93.43% <ø> (ø) ⬆️
html5lib/tests/tokenizer.py 83.33% <ø> (ø) ⬆️
html5lib/_ihatexml.py 45.27% <ø> (ø) ⬆️
html5lib/_utils.py 84.37% <0%> (ø) ⬆️
html5lib/_inputstream.py 91.92% <100%> (ø) ⬆️
html5lib/html5parser.py 97.24% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fea68a...72aa36c. Read the comment docs.

hugovk
hugovk previously approved these changes Nov 8, 2019
@hugovk

This comment has been minimized.

@gsnedders
Copy link
Member

FWIW, I have a preference in favour of pinning flake8 and its dependencies to stop tests from starting failing without changes in html5lib, though preferably in combination with adding some bot to update pinned dependencies.

@jdufresne
Copy link
Contributor Author

No problem. I've changed the PR to keep flake8 pinned, but now to the latest version. All errors are still fixed.

@hugovk
Copy link
Contributor

hugovk commented Feb 25, 2020

preferably in combination with adding some bot to update pinned dependencies.

The two bots I know about: dependabot, now part of GitHub; and pyupbot, which I hear has been a bit flaky of late.

@jdufresne jdufresne changed the title Unpin flake8 and fix all errors Update flake8 to the latest version and fix all errors Feb 25, 2020
@gsnedders
Copy link
Member

Yeah, we use pyupbot on web-platform-tests and it seems to have been going downhill…

The exception is caught and always re-raised without any additional
action. Simply let the original exception bubble up instead.
@gsnedders gsnedders merged commit 986560a into html5lib:master Feb 26, 2020
@jdufresne jdufresne deleted the flake8 branch February 26, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants