-
Notifications
You must be signed in to change notification settings - Fork 294
Update flake8 to the latest version and fix all errors #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 90.52% 90.57% +0.05%
==========================================
Files 50 50
Lines 6973 6968 -5
Branches 1328 1328
==========================================
- Hits 6312 6311 -1
+ Misses 502 498 -4
Partials 159 159
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
FWIW, I have a preference in favour of pinning flake8 and its dependencies to stop tests from starting failing without changes in html5lib, though preferably in combination with adding some bot to update pinned dependencies. |
No problem. I've changed the PR to keep flake8 pinned, but now to the latest version. All errors are still fixed. |
The two bots I know about: dependabot, now part of GitHub; and pyupbot, which I hear has been a bit flaky of late. |
Yeah, we use pyupbot on web-platform-tests and it seems to have been going downhill… |
The exception is caught and always re-raised without any additional action. Simply let the original exception bubble up instead.
No description provided.