test: use Jest with Snapshots #823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
nschonni
force-pushed
the
mocha-snapshot
branch
from
cdcdb86 to
d99f24f
Compare
Used npx jest-codemods to autoconvert then npx jest --init to scaffold out
nschonni
force-pushed
the
mocha-snapshot
branch
from
d99f24f to
c37f60a
Compare
|
Interesting. Forcing on the colour may have resolve some of the issues, but now I need to update that SVG test that was created after the orginal coversion |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage ? 66.86%
=======================================
Files ? 48
Lines ? 3217
Branches ? 360
=======================================
Hits ? 2151
Misses ? 1066
Partials ? 0 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
stale
bot
added
the
bot:stale
stale
bot
removed
the
bot:stale
This comment was marked as outdated.
This comment was marked as outdated.
stale
bot
added
the
bot:stale
nschonni
removed
the
bot:stale
nschonni
added
the
keep-unstale
|
We moved to Jest already and the random CI issues have been resolved so I think this can be closed now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Just trying this one again to see if the random CI issues have resolved
Proposed changes: