Difference in Flux scheduler configuration max_shift

[dxqbYD]

Describe the bug

Could you please check if the value of 1.16 here...

diffusers/src/diffusers/pipelines/flux/pipeline_flux.py

Line 78 in 658e24e

max_shift: float = 1.16,

...is intentional or maybe a typo?

max_shift is 1.15 both in the model configuration...
https://huggingface.co/black-forest-labs/FLUX.1-dev/blob/main/scheduler/scheduler_config.json
...and in the original inference code by BFL:
https://github.com/black-forest-labs/flux/blob/d06f82803f5727a91b0cf93fcbb09d920761fba1/src/flux/sampling.py#L214

Reproduction

Logs

System Info

Who can help?

@yiyixuxu @DN6

[yiyixuxu]

oh yeah not intentional! do you want to help us change?

the config in scheduler is correct, so have should not affect the results https://huggingface.co/black-forest-labs/FLUX.1-dev/blob/main/scheduler/scheduler_config.json#L7

[dxqbYD]

the value is here, too:
https://github.com/huggingface/diffusers/blob/658e24e86c4c52ee14244ab7a7113f5bf353186e/src/diffusers/pipelines/flux/pipeline_flux.py#L852C18-L852C27

Might still not get used as you say, if config.get() prefers the scheduler config