Skip to content

[LoRA] remove full key prefix from peft. #11004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

sayakpaul
Copy link
Member

What does this PR do?

There's some uncertainty around huggingface/peft#2382. So, we decided to remove the full-key prefix thingy from diffusers until huggingface/peft#2382 is merged with a specific direction.

@sayakpaul sayakpaul requested review from BenjaminBossan and hlky March 7, 2025 15:43
Copy link
Contributor

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we try to other proposed fix " storing deleted keys to ensure they aren't re-added by other iterations"

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member Author

hould we try to other proposed fix " storing deleted keys to ensure they aren't re-added by other iterations"

Did you mean?

# remove the ambiguous key from `rank_pattern` and record it as deleted
del config["rank_pattern"][key]
deleted_keys.add(key)

@hlky
Copy link
Contributor

hlky commented Mar 7, 2025

Oh :) all good then!

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick adjustments and sorry again for the inconvenience.

@sayakpaul
Copy link
Member Author

No problem at all!

@sayakpaul sayakpaul merged commit a2d3d6a into main Mar 7, 2025
29 of 30 checks passed
@sayakpaul sayakpaul deleted the remove-full-key-prefix-name branch March 7, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants