Skip to content

[LoRA] change to warning from info when notifying the users about a LoRA no-op #11044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

[LoRA] change to warning from info when notifying the users about a LoRA no-op #11044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed41495
move to warning.
sayakpaul Mar 12, 2025
dcc60f8
test related changes.
sayakpaul Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/diffusers/loaders/lora_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,12 @@ def _load_lora_into_text_encoder(
# Unsafe code />

if prefix is not None and not state_dict:
logger.info(
f"No LoRA keys associated to {text_encoder.__class__.__name__} found with the {prefix=}. This is safe to ignore if LoRA state dict didn't originally have any {text_encoder.__class__.__name__} related params. Open an issue if you think it's unexpected: https://github.com/huggingface/diffusers/issues/new"
logger.warning(
f"No LoRA keys associated to {text_encoder.__class__.__name__} found with the {prefix=}. "
"This is safe to ignore if LoRA state dict didn't originally have any "
f"{text_encoder.__class__.__name__} related params. You can also try specifying `prefix=None` "
"to resolve the warning. Otherwise, open an issue if you think it's unexpected: "
"https://github.com/huggingface/diffusers/issues/new"
)


Expand Down
8 changes: 6 additions & 2 deletions src/diffusers/loaders/peft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,8 +354,12 @@ def load_lora_adapter(self, pretrained_model_name_or_path_or_dict, prefix="trans
# Unsafe code />

if prefix is not None and not state_dict:
logger.info(
f"No LoRA keys associated to {self.__class__.__name__} found with the {prefix=}. This is safe to ignore if LoRA state dict didn't originally have any {self.__class__.__name__} related params. Open an issue if you think it's unexpected: https://github.com/huggingface/diffusers/issues/new"
logger.warning(
f"No LoRA keys associated to {self.__class__.__name__} found with the {prefix=}. "
"This is safe to ignore if LoRA state dict didn't originally have any "
f"{self.__class__.__name__} related params. You can also try specifying `prefix=None` "
"to resolve the warning. Otherwise, open an issue if you think it's unexpected: "
"https://github.com/huggingface/diffusers/issues/new"
)

def save_lora_adapter(
Expand Down
4 changes: 2 additions & 2 deletions tests/lora/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1961,7 +1961,7 @@ def test_logs_info_when_no_lora_keys_found(self):

no_op_state_dict = {"lora_foo": torch.tensor(2.0), "lora_bar": torch.tensor(3.0)}
logger = logging.get_logger("diffusers.loaders.peft")
logger.setLevel(logging.INFO)
logger.setLevel(logging.WARNING)

with CaptureLogger(logger) as cap_logger:
pipe.load_lora_weights(no_op_state_dict)
Expand All @@ -1981,7 +1981,7 @@ def test_logs_info_when_no_lora_keys_found(self):
prefix = "text_encoder_2"

logger = logging.get_logger("diffusers.loaders.lora_base")
logger.setLevel(logging.INFO)
logger.setLevel(logging.WARNING)

with CaptureLogger(logger) as cap_logger:
self.pipeline_class.load_lora_into_text_encoder(
Expand Down
Loading