-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[Training] Better image interpolation in training scripts #11206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the comments are resolved.
Co-authored-by: hlky <[email protected]>
parser.add_argument( | ||
"--image_interpolation_mode", | ||
type=str, | ||
default="lanczos", | ||
choices=[ | ||
f.lower() for f in dir(transforms.InterpolationMode) if not f.startswith("__") and not f.endswith("__") | ||
], | ||
help="The image interpolation method to use for resizing images.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asomoza hope this is okay.
Failing test is unrelated. |
What does this PR do?
As discussed here, this PR will add LANCZOS as a default interpolation mode for the image resizing in the training scripts and if the users prefers can choose BILINEAR.
I'll add this to the most popular recent ones and leave the rest to the community if they want to add them to other training scripts.
I'll do some training runs first to test if I can see the difference, but still, I already know that LANCZOS is better and that the models can pick subtle details that the human eye can't.
Fixes #6397
Who can review?
@bghira @linoytsaban @sayakpaul
Additional
Here's a little script if you want to test and try to see the difference: