[Feature] MultiControlNet support for SD3Impainting #11251
Conversation
| raise NotImplementedError("MultiControlNetModel is not supported for SD3ControlNetInpaintingPipeline.") | ||
| control_images = [] | ||
|
|
||
| for control_image_ in control_image: |
There was a problem hiding this comment.
This will fail if control_image is not passed as a list. Looks like SD3 ControlNet and Flux ControlNet pipelines are missing checks for this. See ControlNet Union XL as an example.
There was a problem hiding this comment.
hmm, it should fail, no?
if isinstance(self.controlnet, SD3ControlNetModel): this statement is a single controlnet model and expects a single image
elif isinstance(self.controlnet, SD3MultiControlNetModel): this statement is multiple controlnet stacked and expects list of images one image per controlnet
let me know if I am missing something ?
There was a problem hiding this comment.
Yes, it is expected to fail, but gracefully.
expects list of images one image per controlnet
These checks are missing.
See ControlNet Union XL as an example.
|
@hlky, gentle ping |
What does this PR do?
Fixes #11208
Who can review?
@yiyixuxu