Pipeline deprecations #11354
Pipeline deprecations #11354
Conversation
…iffusers into pipeline-deprecate
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| @@ -25,7 +25,7 @@ | |||
| ): | |||
| raise OptionalDependencyNotAvailable() | |||
| except OptionalDependencyNotAvailable: | |||
| from ...utils import dummy_torch_and_transformers_and_k_diffusion_objects # noqa F403 | |||
| from ....utils import dummy_torch_and_transformers_and_k_diffusion_objects # noqa F403 | |||
|
|
|||
| _dummy_objects.update(get_objects_from_module(dummy_torch_and_transformers_and_k_diffusion_objects)) | |||
| else: | |||
There was a problem hiding this comment.
Not sure whether to deprecate K Diffusion. The approach is still reasonably popular. It's just that the original implementation isn't very actively maintained, so thought it made sense to move ours to deprecated as well. I'm cool moving it back if we feel strongly against deprecating.
There was a problem hiding this comment.
I think it's ok! it's not that they cannot use it anymore
| @@ -333,7 +333,7 @@ def prepare_extra_step_kwargs(self, generator, eta): | |||
| extra_step_kwargs["generator"] = generator | |||
| return extra_step_kwargs | |||
|
|
|||
| # Copied from diffusers.pipelines.latte.pipeline_latte.LattePipeline.check_inputs | |||
| # Copied from diffusers.pipelines.deprecated.latte.pipeline_latte.LattePipeline.check_inputs | |||
There was a problem hiding this comment.
Not sure how much usage does this pipeline have but maybe we could move this one to deprecated too in view of CogView4?
There was a problem hiding this comment.
Sounds good, CogView3Plus has very few downloads compared to CogView4. I'm still not sure why we need to deprecate pipelines though. If it's to release stress from the CI, we could just disable the tests, no? Do we plan to support these via modular diffusers, or completely discontinue/remove support eventually?
There was a problem hiding this comment.
Yeah, I think the idea would be to transition them out of src to community pipelines by release 1.0.0. They could also be turned into modular components if there is interest.
Deprecation is just to communicate that the maintainers won't be updating or fixing stuff in these pipelines moving forward.
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.