Skip to content

[train_text_to_image_sdxl]Add LANCZOS as default interpolation mode for image resizing #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 5, 2025

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Apr 29, 2025

What does this PR do?

Refs #11390

As mentioned in the issue, I've updated LANCZOS as the default interpolation mode for the training script. Please let me know if any modifications are required and I will make the necessary changes.

Before submitting

Who can review?

@asomoza

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@asomoza asomoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, just a minor correction

Co-authored-by: Álvaro Somoza <[email protected]>
@ParagEkbote ParagEkbote requested a review from asomoza April 30, 2025 06:55
@asomoza
Copy link
Member

asomoza commented May 2, 2025

thanks @ParagEkbote, as a final step, for contributing in diffusers you have to format the code, can you run these two commands on the console:

make style
make quality

If for some reason you can't run them, I can run a bot that does this for you, but it's always better to run it yourself, specially for larger contributions of code with multiple reviews.

@ParagEkbote
Copy link
Contributor Author

I have run both the commands for code quality and linting. Could you please review the changes?

cc: @asomoza

@asomoza asomoza merged commit fc5e906 into huggingface:main May 5, 2025
9 checks passed
@ParagEkbote ParagEkbote deleted the Improve-Image-Interpolation branch May 5, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants