-
Notifications
You must be signed in to change notification settings - Fork 6k
feat: add act_fn
param to OutValueFunctionBlock
#3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add act_fn
param to OutValueFunctionBlock
#3994
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Let's add some folks from the Diffusers team, I'm not actively working on this anymore @patrickvonplaten |
I don't fully understand what this fixes. Could you maybe elaborate here @SauravMaheshkar ? :-) |
Co-authored-by: Patrick von Platen <[email protected]>
Hey @patrickvonplaten thanks for getting back. This doesn't fix an issue but I rather wanted to raise the discussion about how to fix #1287. A very naive fix could be to simply change the activation to But if not what would you suggest is a way to fix it ? I'm afraid I can't understand #1287 (comment) |
TBH, I also don't fully understand the discussion of #1287 - I'm ok with merging this PR as is though if it helps for your use case :-) |
Well this PR changes the activation function to be |
Perfect! |
* feat: add act_fn param to OutValueFunctionBlock * feat: update unet1d tests to not use mish * feat: add `mish` as the default activation function Co-authored-by: Patrick von Platen <[email protected]> * feat: drop mish tests from unet1d --------- Co-authored-by: Patrick von Platen <[email protected]>
* feat: add act_fn param to OutValueFunctionBlock * feat: update unet1d tests to not use mish * feat: add `mish` as the default activation function Co-authored-by: Patrick von Platen <[email protected]> * feat: drop mish tests from unet1d --------- Co-authored-by: Patrick von Platen <[email protected]>
* feat: add act_fn param to OutValueFunctionBlock * feat: update unet1d tests to not use mish * feat: add `mish` as the default activation function Co-authored-by: Patrick von Platen <[email protected]> * feat: drop mish tests from unet1d --------- Co-authored-by: Patrick von Platen <[email protected]>
* feat: add act_fn param to OutValueFunctionBlock * feat: update unet1d tests to not use mish * feat: add `mish` as the default activation function Co-authored-by: Patrick von Platen <[email protected]> * feat: drop mish tests from unet1d --------- Co-authored-by: Patrick von Platen <[email protected]>
* feat: add act_fn param to OutValueFunctionBlock * feat: update unet1d tests to not use mish * feat: add `mish` as the default activation function Co-authored-by: Patrick von Platen <[email protected]> * feat: drop mish tests from unet1d --------- Co-authored-by: Patrick von Platen <[email protected]>
What does this PR do?
(Hopefully) fixes #1287
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Request for Review: @natolambert