Skip to content

Fix an error when DPM Solver Single Step contains duplicate timesteps #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cmdr2
Copy link
Contributor

@cmdr2 cmdr2 commented Jul 24, 2023

Uses the de-duplication logic applied to the other samplers in #2969

I think this sampler got missed?

This change fixes an error when duplicate timesteps are created with the karras flag: ValueError: only one element tensors can be converted to Python scalars

@patrickvonplaten @sayakpaul

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@cmdr2
Copy link
Contributor Author

cmdr2 commented Jul 24, 2023

I'm really not sure how to fix the non-passing test. It seems to be due to the order_list, which causes the order to stay at 2 (instead of 1), which results in the sample not getting assigned to self.sample.

cmdr2 added a commit to easydiffusion/sdkit that referenced this pull request Jul 24, 2023
@patrickvonplaten
Copy link
Contributor

I think this is related: #4187

Could you take a look @yiyixuxu ?

@yiyixuxu yiyixuxu assigned yiyixuxu and unassigned yiyixuxu Jul 24, 2023
@yiyixuxu
Copy link
Collaborator

Thanks for your PR @cmdr2 :)

We are trying to see if we can move away from the de-duplicate logic altogether in this PR #4187

will keep you updated!

YiYi

@cmdr2
Copy link
Contributor Author

cmdr2 commented Jul 25, 2023

Thanks @yiyixuxu! Sounds good, looks like a better path. I noticed the index_counter approach in DPM Solver SDE as well.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Aug 23, 2023
@github-actions github-actions bot closed this Aug 31, 2023
@cmdr2
Copy link
Contributor Author

cmdr2 commented Sep 1, 2023

This error has not been resolved, and the other PR hasn't been merged either (it's been marked as stale).

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@yiyixuxu
Copy link
Collaborator

fixed in #4986

@yiyixuxu yiyixuxu closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't received updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants