Skip to content

Update Tests Fetcher #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Dec 4, 2023
Merged

Update Tests Fetcher #5950

merged 31 commits into from
Dec 4, 2023

Conversation

DN6
Copy link
Collaborator

@DN6 DN6 commented Nov 27, 2023

What does this PR do?

Tests fetcher on PRs is currently running all tests in Github actions due to how GA performs checkout. The Github Actions checkout does not have a local refs to main (which is what test fetcher attempts to use to diff the PR and find the changes).

This PR

  1. Changes it so tests fetcher diffs the PR with the the upstream main branch to correctly figure out the tests.
  2. Adds support to run the tests for Core Pipelines for every PR in a dedicated job
  3. Changes the logic so that when tests fetcher has to run all tests in the suite, it will filter out the pipelines to run core pipeline tests only, instead of testing every pipeline.
  4. Updates the GitPython version in the deps table to match the version in transformers for parity.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@patrickvonplaten
Copy link
Contributor

Ok to merge once quality tests pass

@DN6 DN6 changed the title Update setup and deps table Update Tests Fetcher Dec 1, 2023
@DN6
Copy link
Collaborator Author

DN6 commented Dec 4, 2023

Failing test related to convert_kandinksy file being in the wrong location. Will open a new PR to move that.

@DN6 DN6 merged commit b217292 into main Dec 4, 2023
@kashif kashif deleted the test-fetcher-update branch December 5, 2023 08:59
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* update setup and deps table

* update

* update

* update

* up

* up

* update

* up

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* quality fix

* fix failure reporting

---------

Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* update setup and deps table

* update

* update

* update

* up

* up

* update

* up

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* quality fix

* fix failure reporting

---------

Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants