Enable image resizing to adjust its height and width in StableDiffusionXLInstructPix2PixPipeline #6581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onXLInstructPix2PixPipeline
sangyeon-k
commented
Jan 15, 2024
| @@ -1109,7 +1109,7 @@ def collate_fn(examples): | |||
| progress_bar.set_postfix(**logs) | |||
|
|
|||
| ### BEGIN: Perform validation every `validation_epochs` steps | |||
| if global_step % args.validation_steps == 0 or global_step == 1: | |||
There was a problem hiding this comment.
Do we have to perform validation at every step? I believe we might not need to.
This PR did not originally intend for this change, but what do you think about removing the condition global_step==1?
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
Jan 16, 2024
| @@ -858,7 +858,7 @@ def __call__( | |||
| ) | |||
|
|
|||
| # 4. Preprocess image | |||
| image = self.image_processor.preprocess(image).to(device) | |||
| image = self.image_processor.preprocess(image, height=height, width=width).to(device) | |||
sayakpaul
approved these changes
Jan 16, 2024
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…onXLInstructPix2PixPipeline (huggingface#6581) * Enable image resizing to adjust its height and width in StableDiffusionXLInstructPix2PixPipeline * Ensure that validation is performed at every 'validation_step', not at every step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6570.
In
StableDiffusionXLInstructPix2PixPipeline, a shape discrepancy betweenimage_latentsandlatentscan occur if theheightandwidthparameters are not explicitly initialized by the user.Therefore, to tackle this problem, this PR enables image resizing to adjust its height and width.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul