Skip to content

Add clip_skip param for StableDiffusionLongPromptWeightingPipeline #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

calmiLovesAI
Copy link

@calmiLovesAI calmiLovesAI commented Jan 26, 2024

What does this PR do?

This PR add a clip_skip parameter for lpw_stable_diffusion.py.

Fixes #6414

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu
Copy link
Collaborator

yiyixuxu commented Feb 8, 2024

hi:
can you fix the quality test?

@calmiLovesAI
Copy link
Author

hi: can you fix the quality test?

hi, I don't know what this means in Run code quality checks

Run ruff check examples tests src utils scripts
Would reformat: examples/community/lpw_stable_diffusion.py
1 file would be reformatted, 801 files left unchanged
Error: Process completed with exit code 1.

Can you help me?

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Mar 13, 2024
@dwgrth
Copy link

dwgrth commented Feb 4, 2025

I've fixed the quality test in this branch:
https://github.com/dwgrth/diffusers/tree/add_clip_skip

I'm not sure how to contribute to this PR though.

@asomoza asomoza added close-to-merge and removed stale Issues that haven't received updates labels Feb 4, 2025
@asomoza
Copy link
Member

asomoza commented Feb 5, 2025

Hi, as a note, the author of the pipeline discontinued support for the lpw pipelines in favor of using the most up to date core pipelines with the external library sd_embeds from the same author which is actively maintained.

Not sure it's worth to keep updating these pipelines, especially since there was some issues with some of the updates from the community.

@calmiLovesAI if you still want to merge the PR, just use the cli commands:

make style
make quality

Anyways, to pass the test, you just need to add the trailing comma to some of the clip_skip=clip_skip args you added that are missing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clip Skip with LPW pipeline?
5 participants