-
Notifications
You must be signed in to change notification settings - Fork 6k
fix: enable unet_3d_condition to support time_cond_proj_dim #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks for the PR. Is this for a use case? Just curious. |
Hi, I encountered this problem when trying to replace the UNet2DConditionModel with UNet3DConditionModel in consistency model training example. In the original code, This PR enables the consistency model training example to support 3D Unet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with the change. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@yhZhai please ping us once the CI run is complete. |
@sayakpaul @yiyixuxu @DN6 Hi all, the CI run has completed. Could you please take a look? Thank you! |
Sorry this needs to be run again because previously, the CI was broken (for an internal mistake). Should hopefully be fixed 🤞 |
@sayakpaul Hi, could you please take a look at the CI test result? Thanks! |
Thank you for your contributions! |
…ace#7364) Co-authored-by: Sayak Paul <[email protected]>
What does this PR do?
This PR adds an argument
time_cond_proj_dim
to UNet3DConditionModel (the same as UNet2DConditionModel), and thus it enables the time_embedding module to create a cond_proj module.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.