-
Notifications
You must be signed in to change notification settings - Fork 6k
Animatediff Controlnet Community Pipeline IP Adapter Fix #7413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animatediff Controlnet Community Pipeline IP Adapter Fix #7413
Conversation
Could you also tag the author who contributed the pipeline for a review? |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This is bizarre, I'm not sure how it even passed locally in the other PR! The issue comes from encode_image not being the latest implementation. It seems like The changes in this PR are incorrect btw. For both AnimateDiff controlnet/img2vid, could you update the encode_image function to this:
Edit: I see the issue that caused this. In my original PR, I did update to latest encode_image function. However, I was working on multiple things at the time and overlapped branches quite stupidly. When I tested, it worked as expected because it was the overlapping branch instead of the base that added latest IP Adapter support 🤦 Apologies for breaking the implementation, I'll be more careful next time |
@sayakpaul @yiyixuxu From a quick look at the |
Yeah we don't don't copy checks on community pipelines. |
a1beedb
to
de9adb9
Compare
Fixed as requested above. It's a bit weird though, as this optional variable is never used in the encode_image function. |
Please copy the entire function body of encode_image from the latest SD pipeline implementation. Please also do it for animatediff img2vid in this PR if possible as both pipelines suffer from common issue. |
Gotcha! And the error doesn't seem to be there for the img2video pipeline |
Oh I see, I'm looking at my local branches that were not synced and comparing against here. Looks good to go now! Thanks Would be great if you could run the example code and verify if everything's working again |
Seems to work! |
cc @DN6 |
* fixed encode_image function signature in controlnet animatediff * copied encode_image from stable diffusion pipeline --------- Co-authored-by: YiYi Xu <[email protected]>
What does this PR do?
The animatediff controlnet community pipeline had a small bug that supplied an incorrect parameter to encode_image. I pushed the fix for it.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @yiyixuxu @DN6 @a-r-r-o-w