Skip to content

fix _optional_components in StableCascadeCombinedPipeline #7894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2024

Conversation

yiyixuxu
Copy link
Collaborator

@yiyixuxu yiyixuxu commented May 9, 2024

currently, StableCascadeCombinedPipeline is missing _optional_components so the combined pipeline is not able to get the correct list of expected modules, i.e. _get_signature_keys (

def _get_signature_keys(cls, obj):
) will not include the optional components in expected_modules, which will then cause errors in methods using this methods, such as components and to

this fix #7598

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏽

@yiyixuxu yiyixuxu merged commit 5ed3abd into main May 9, 2024
17 checks passed
@yiyixuxu yiyixuxu deleted the fix-combined-to branch May 9, 2024 16:32
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CombinedPipeline fails to accept bfloat16 image tensor as input
3 participants