[Tests] fix things after #7013 #7899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
changed the title
sayakpaul
commented
May 9, 2024
| @@ -1294,7 +1294,7 @@ def set_lora_device(self, adapter_names: List[str], device: Union[torch.device, | |||
| text_encoder_module.lora_B[adapter_name].to(device) | |||
| # this is a param, not a module, so device placement is not in-place -> re-assign | |||
| if ( | |||
| hasattr(text_encoder, "lora_magnitude_vector") | |||
| hasattr(text_encoder_module, "lora_magnitude_vector") | |||
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#7013 changed the order of channels in the watermarked which is used in our CI. This led to some assertion failures, as seen here: https://github.com/huggingface/diffusers/actions/runs/8943160603/job/24567270848#step:7:3396.
For
FAILED tests/lora/test_lora_layers_sdxl.py::LoraSDXLIntegrationTests::test_sdxl_lcm_lora, I did https://huggingface.co/datasets/hf-internal-testing/diffusers-images/discussions/39.Additionally, I fixed the reason why
tests/lora/test_lora_layers_sd.py::StableDiffusionLoRATests::test_integration_move_lora_dora_cpuwas failing.Other failing tests are likely because of caching issues. Once that is resolved and if we observe assertion problems, I will fix them as we go.