make pipelines tests device-agnostic (part1)
#9399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide some details about the machine you used to run the tests changed in this PR? |
yes, I am running on Intel(R) Data Center GPU Max 1550. |
xpu is the common device name for intel gpu. |
|
Hi @sayakpaul , any concern on this PR? |
|
could you pls help retrigger the CI? Thx a lot! |
yiyixuxu
reviewed
Nov 8, 2024
DN6
reviewed
Nov 8, 2024
Co-authored-by: Dhruv Nair <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
Co-authored-by: Dhruv Nair <[email protected]>
|
Thanks for the comments. Code Update! |
|
@faaany your changes didn't pass the code quality check, can you do |
done |
a-r-r-o-w
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks for the awesome work here! I think this looks good to merge and the failing tests are unrelated (I've restarted them anyway to make it go away). Off to @DN6 for merging since he has much more experience on the tests front
|
Hi @DN6 , could you take a look at this PR? |
DN6
approved these changes
Nov 22, 2024
lawrence-cj
pushed a commit
to lawrence-cj/diffusers
that referenced
this pull request
Nov 26, 2024
* enable on xpu * add 1 more * add one more * enable more * add 1 more * add more * enable 1 * enable more cases * enable * enable * update comment * one more * enable 1 * add more cases * enable xpu * add one more caswe * add more cases * add 1 * add more * add more cases * add case * enable * add more * add more * add more * enbale more * add more * update code * update test marker * add skip back * update comment * remove single files * remove * style * add * revert * reformat * update decorator * update * update * update * Update tests/pipelines/deepfloyd_if/test_if.py Co-authored-by: Dhruv Nair <[email protected]> * Update src/diffusers/utils/testing_utils.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <[email protected]> * update float16 * no unitest.skipt * update * apply style check * reapply format --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: Dhruv Nair <[email protected]>
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* enable on xpu * add 1 more * add one more * enable more * add 1 more * add more * enable 1 * enable more cases * enable * enable * update comment * one more * enable 1 * add more cases * enable xpu * add one more caswe * add more cases * add 1 * add more * add more cases * add case * enable * add more * add more * add more * enbale more * add more * update code * update test marker * add skip back * update comment * remove single files * remove * style * add * revert * reformat * update decorator * update * update * update * Update tests/pipelines/deepfloyd_if/test_if.py Co-authored-by: Dhruv Nair <[email protected]> * Update src/diffusers/utils/testing_utils.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff.py Co-authored-by: Dhruv Nair <[email protected]> * Update tests/pipelines/animatediff/test_animatediff_controlnet.py Co-authored-by: Dhruv Nair <[email protected]> * update float16 * no unitest.skipt * update * apply style check * reapply format --------- Co-authored-by: Sayak Paul <[email protected]> Co-authored-by: Dhruv Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Below are some evidences:
@yiyixuxu