-
Notifications
You must be signed in to change notification settings - Fork 6k
[LoRA] Implement hot-swapping of LoRA #9453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 45 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
d3fbd7b
[WIP][LoRA] Implement hot-swapping of LoRA
BenjaminBossan 84bae62
Reviewer feedback
BenjaminBossan 63ece9d
Reviewer feedback, adjust test
BenjaminBossan 94c669c
Merge branch 'main' into lora-hot-swapping
BenjaminBossan c7378ed
Fix, doc
BenjaminBossan 7c67b38
Make fix
BenjaminBossan ea12e0d
Fix for possible g++ error
BenjaminBossan ec4b0d5
Add test for recompilation w/o hotswapping
BenjaminBossan e07323a
Merge branch 'main' into lora-hot-swapping
sayakpaul 529a523
Merge branch 'main' into lora-hot-swapping
sayakpaul ac1346d
Merge branch 'main' into lora-hot-swapping
sayakpaul 58b35ba
Merge branch 'main' into lora-hot-swapping
BenjaminBossan d21a988
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 488f2f0
Make hotswap work
BenjaminBossan ece3d0f
Merge branch 'main' into lora-hot-swapping
sayakpaul 5ab1460
Address reviewer feedback:
BenjaminBossan bc157e6
Change order of test decorators
BenjaminBossan bd1da66
Split model and pipeline tests
BenjaminBossan 119a8ed
Reviewer feedback: Move decorator to test classes
BenjaminBossan 53c2f84
Merge branch 'main' into lora-hot-swapping
BenjaminBossan a715559
Apply suggestions from code review
BenjaminBossan e40390d
Reviewer feedback: version check, TODO comment
BenjaminBossan 1b834ec
Add enable_lora_hotswap method
BenjaminBossan 4b01401
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 2cd3665
Reviewer feedback: check _lora_loadable_modules
BenjaminBossan efbd820
Merge branch 'main' into lora-hot-swapping
BenjaminBossan e735ac2
Revert changes in unet.py
BenjaminBossan 69b637d
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 3a6677c
Add possibility to ignore enabled at wrong time
BenjaminBossan a96f3fd
Fix docstrings
BenjaminBossan deab0eb
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 2c6b435
Log possible PEFT error, test
BenjaminBossan ccb45f7
Raise helpful error if hotswap not supported
BenjaminBossan 09e2ec7
Formatting
BenjaminBossan 67ab6bf
More linter
BenjaminBossan f03fe6b
More ruff
BenjaminBossan 2d407ca
Doc-builder complaint
BenjaminBossan 6b59ecf
Update docstring:
BenjaminBossan f14146f
Merge branch 'main' into lora-hot-swapping
yiyixuxu a79876d
Merge branch 'main' into lora-hot-swapping
BenjaminBossan c3c1bdf
Fix error in docstring
BenjaminBossan 387ddf6
Update more methods with hotswap argument
BenjaminBossan 7f72d0b
Merge branch 'main' into lora-hot-swapping
BenjaminBossan dec4d10
Add hotswap argument to load_lora_into_transformer
BenjaminBossan 204f521
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 716f446
Extend docstrings
BenjaminBossan 4d82111
Add version guards to tests
BenjaminBossan 425cb39
Formatting
BenjaminBossan 115c77d
Fix LoRA loading call to add prefix=None
BenjaminBossan 5d90753
Run make fix-copies
BenjaminBossan 62c1c13
Merge branch 'main' into lora-hot-swapping
BenjaminBossan d6d23b8
Merge branch 'main' into lora-hot-swapping
BenjaminBossan 366632d
Add hot swap documentation to the docs
BenjaminBossan b181a47
Apply suggestions from code review
BenjaminBossan f2a6146
Merge branch 'main' into lora-hot-swapping
BenjaminBossan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.