This repository was archived by the owner on Feb 8, 2021. It is now read-only.
add service files #152
Merged
add service files #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
suggested changes
Oct 9, 2016
| Description=Kubernetes Kubelet Server | ||
| Documentation=https://github.com/GoogleCloudPlatform/kubernetes | ||
| After=docker.service | ||
| Requires=docker.service |
There was a problem hiding this comment.
we don't require docker. those two lines should be removed.
There was a problem hiding this comment.
OK. But I will take some time to test this pr because of the poor network environment.
There was a problem hiding this comment.
@xlgao-zju Yep, network is a big problem. Thanks for the work.
Signed-off-by: Xianglin Gao <[email protected]>
xlgao-zju
force-pushed
the
add-service-files
branch
from
7c9593a to
89cbe96
Compare
|
@feiskyer updated. And it seems fine on centos 7.2. |
feiskyer
approved these changes
Oct 11, 2016
|
Cool, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #149
Signed-off-by: Xianglin Gao [email protected]