Skip to content

fix: add missing feature flags #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tomkarw
Copy link
Contributor

@tomkarw tomkarw commented Aug 20, 2022

Closes https://github.com/hyperium/hyper-util/issues/7.

This PR:

  • adds missing feature flags that were referenced in code, but not in Cargo.toml: runtime, tcp, http1, http2
  • copies Never struct from hyper and uses it in client module to make it compile when features are enabled
  • fixes 3 Clippy warnings about preferring Copy to Clone

There is one test still failing: client::connect::http::tests::client_happy_eyeballs. It's a bit over my head, so I didn't attempt to fix it.

@tomkarw
Copy link
Contributor Author

tomkarw commented Aug 20, 2022

The fact that the all checks pass, even though there is a failing test, is worrying. It's also the reason code that doesn't compile was merged.

I'll make cargo check and cargo test use --all-features flag.
The project already includes something called cargo-hack, but it doesn't seem to serve its purpose.

I'll wait for @seanmonstar for guidance.

@tomkarw tomkarw force-pushed the tomkarw/fix-add-missing-feature-flags branch from a3adb4c to 11d0ab2 Compare August 20, 2022 19:28
@seanmonstar seanmonstar merged commit 85aade4 into hyperium:master Aug 22, 2022
@tomkarw tomkarw deleted the tomkarw/fix-add-missing-feature-flags branch August 23, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of #[cfg(feature = ...)] in code without the corresponding features in Cargo.toml
2 participants