Skip to content

HTTP2 should respect flow control #1548

Closed
@seanmonstar

Description

@seanmonstar

Currently sending bodies will just push unbounded into the h2 buffer. While this works, unbounded buffering is not so great. Instead, hyper should check for existing window capacity before polling the body for data.

Steps to fix

  • Basically, update proto::h2::PipeToSendStream similar to how it was done in this commit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-bodyArea: body streaming.A-http2Area: HTTP/2 specific.C-featureCategory: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions