Skip to content

http2::handshake() is useless in 1.0 given no default executor #3128

Closed
@conradludgate

Description

@conradludgate

Version

hyper 1.0.0-rc2

Description

hyper::client::conn::http2::handshake(io).await causes an instant panic. Internally it performs Builder::new().handshake(io).await which uses the Exec::Default executor. There is no longer a default tokio runtime implied since the removal of the runtime feature.

https://github.com/hyperium/hyper/blob/master/src/common/exec.rs#L36-L38

There is a TODO in this file to refactor executors. But I couldn't find a relevant issue, so I wanted to open one to ensure this doesn't get included in the official release

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-breaking-changeBlocked: this is an "API breaking change".C-bugCategory: bug. Something is wrong. This is bad!

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions