Add Proxy support to Client

[seanmonstar]

I imagine some sort of Proxy type being added a property of Client, with a corresponding set_proxy(Option<Proxy>) method.

Use of a proxy can have different requirements: all requests, only https requests, only http... So it would probably mean Proxy would be an enum... and the proxy would be consulted in the RequestBuilder.send method.

[messense]

It would be awesome to have this feature!

[shaleh]

Yes please. Some of us need this to use Rust at work.

[shaleh]

Something like:

let mut client = Client::new();
// after checking config, env for HTTP_PROXY, whatever
let proxy = Proxy::new(server, port, scheme);  // AuthProxy::new for the more complicated cases
client.add_proxy(proxy);  // set_proxy, which ever. Bike shed as needed
// now a request using 'scheme' will be proxied
client.get(....)

[mattnenterprise]

I would like to give this a try.

[mattnenterprise]

@seanmonstar Could you give more information on how you think this should be implemented?

[seanmonstar]

@mattnenterprise an api suggested by @shaleh looks fine. It'd likely require adding a method to Request to change the RequestUri, since the full url is needed instead of just the path.

[shaleh]

Note the requirement for a list of proxies. When the final HTTP call is made it should check the request's scheme against defined proxies for a matching scheme.

[shaleh]

Since Rust does not support optional arguments I used AuthProxy in my example for the case where the proxy needs authentication. If this is too cumbersome using Option for the credentials is probably OK.

[shaleh]

I think using a container for the proxies avoids the need for Option<Proxy>. Just walk it and compare schemes. Since the list will only every be a few items long it is sane to walk it. No need for a hash or other lookup table.

[seanmonstar]

There's a PR for this at #639, if others interested in this feature could help looking it over.

[winding-lines]

Hello everybody, I have been working on the proxy implementation for a while (on and off) but I missed this conversation :-) I will evolve my PR based on this feedback.

[kikokikok]

Hi All,
I've just been tracking down the reason why multirust-rs is not able to work behind a proxy, It seems like the Http Client used in multirust is the Hyper one which leads me to this discussion and the associated PR.

Do you have an ETA on this one ? it seems like it hasn't evolved since October. Any chance to see this merged or is it still not mature enough.
I see a lot of value in having this functionality built-in Hyper as it serves a lot of tools/libs in the ecosystem and could clearly help to drive Enterprise adoption.

Thanks !

[mitsuhiko]

I'm in the same boat. I really need proxy support. Is there any chance I can help out with this?