feat(client): allow both IPv6 and IPv4 local addresses #2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikulin
force-pushed
the
gh-2169
branch
3 times, most recently
from
10408ea to
71b8045
Compare
|
gitcop is not happy with the commit message for some reason. Though, I've tried to follow the guidelines. Can someone clarify what's wrong with it please? |
inikulin
force-pushed
the
gh-2169
branch
2 times, most recently
from
c3976b3 to
fe6b9dd
Compare
|
@seanmonstar Sorry for poking you, but may ask your feedback on the PR? |
inikulin
force-pushed
the
gh-2169
branch
3 times, most recently
from
d92c485 to
a5e94ac
Compare
|
hopeless bump |
|
@seanmonstar Sorry for the ping again, your feedback will be appreciated |
seanmonstar
requested changes
Oct 7, 2020
|
@seanmonstar addressed the comments |
seanmonstar
reviewed
Oct 13, 2020
Currently HttpConnector::set_local_address method accepts a single argument. Server might not support IPv6 or IPv4. Therefore, the only solution at the moment is to manually perform DNS resolution and pick appropriate local address family. This is inefficient, as leads to 2 DNS lookups per request. This commit allows specifying both IPv4 and IPv6, so connector can decide which one to use based on DNS resolution results.
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
…v6 and IPv4 local addrs (hyperium#2172) Currently HttpConnector::set_local_address method accepts a single argument. Server might not support IPv6 or IPv4. Therefore, the only solution at the moment is to manually perform DNS resolution and pick appropriate local address family. This is inefficient, as leads to 2 DNS lookups per request. This commit allows specifying both IPv4 and IPv6, so connector can decide which one to use based on DNS resolution results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2169