Skip to content

http1 expose ignore_invalid_headers_in_requests opt #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

http1 expose ignore_invalid_headers_in_requests opt #3824

merged 1 commit into from
Jan 14, 2025

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Jan 9, 2025 •
edited
Loading

Fixes #3825

@GlenDC GlenDC mentioned this pull request Jan 9, 2025
Closed
@seanmonstar
Copy link
Member

This probably requires a newer version of httparse in the Cargo.toml, to the version that method was introduced.

@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from 503f6c3 to 129a448 Compare January 9, 2025 22:05
@GlenDC
Copy link
Contributor Author

GlenDC commented Jan 9, 2025

This probably requires a newer version of httparse in the Cargo.toml, to the version that method was introduced.

Seems so: https://github.com/seanmonstar/httparse/releases/tag/v1.9.0

@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from 129a448 to ac9d487 Compare January 9, 2025 22:06
seanmonstar
seanmonstar requested changes Jan 10, 2025
View reviewed changes
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from ac9d487 to c521b50 Compare January 10, 2025 21:50
@GlenDC GlenDC requested a review from seanmonstar January 10, 2025 21:51
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from c521b50 to be248e7 Compare January 10, 2025 21:52
@GlenDC GlenDC force-pushed the patch/ignore-invalid-header-request branch from be248e7 to e8a4206 Compare January 10, 2025 21:56
seanmonstar
seanmonstar approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@seanmonstar seanmonstar merged commit 3817a79 into hyperium:master Jan 14, 2025
22 checks passed
GlenDC added a commit to plabayo/rama that referenced this pull request Feb 20, 2025
@GlenDC @seanmonstar
@finnbear @tottoto
sync rama-http-core code with hyperium/hyper v1.6.0
764b8a6 
- ext: add ext::on_informational() callback extension
  (<hyperium/hyper#3818>)
  (<hyperium/hyper@8ce1fcf>,
    closes <hyperium/hyper#2565>)
- server: add http1::Builder::ignore_invalid_headers(bool) option
  (<hyperium/hyper#3824>)
  (<hyperium/hyper@3817a79>)

- server:
    - start http1 header read timeout when conn is idle
      (<hyperium/hyper#3828>)
      (<hyperium/hyper@10b09ff>,
        closes <hyperium/hyper#3780>,
          <hyperium/hyper#3781>)
    - change max_local_error_reset_streams function to &mut self (#3820) (e981a91e)

- http2::Builder::max_local_error_reset_streams() now takes
  &mut self and returns &mut Self. In practice, this shouldn't break almost anyone.
  It was the wrong receiver and return types.
  (<hyperium/hyper@e981a91>)

Co-authored-by: Sean McArthur <[email protected]>
Co-authored-by: Finn Bear <[email protected]>
Co-authored-by: tottoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore_invalid_headers option for HTTP/1 server requests
2 participants
@GlenDC @seanmonstar