refactor(error): remove redundant parts of error names #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ use std::str::FromStr; | |||
| use url::Url; | |||
| use url::ParseError as UrlError; | |||
|
|
|||
| use error::HttpError; | |||
| use error::Error; | |||
|
LGTM except for that nit |
seanmonstar
force-pushed
the
error-rename
branch
from
ebb1078 to
2b6fbdb
Compare
|
Just holding on merging till I've completed some other breaking changes, and they can all be part of 0.4 |
The old names followed the old style of including the module name and "Error" in each variant. The new style is to refer to an error from its owning module, and variants are now scoped to their enum, so there's no need to include the enum name in the variant name. BREAKING CHANGE: The terms `Http` and `Error` have been removed from the Error type and its variants. `HttpError` should now be accessed as `hyper::Error`, and variants like `HttpIoError` should be accessed as `Error::Io`.
seanmonstar
added a commit
that referenced
this pull request
May 5, 2015
refactor(error): remove redundant parts of error names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old names followed the old style of including the module name and
"Error" in each variant. The new style is to refer to an error from its
owning module, and variants are now scoped to their enum, so there's no
need to include the enum name in the variant name.
BREAKING CHANGE: The terms
HttpandErrorhave been removed from the Errortype and its variants.
HttpErrorshould now be accessed ashyper::Error,and variants like
HttpIoErrorshould be accessed asError::Io.