Add a license badge to README.md #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:
Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
|
Whoops. One sec while I force-push a commit fix. |
|
There. Sorry about that. My sleep cycle is somewhat disrupted and I forgot to consider how it subtly affects my memory and judgement. EDIT: ...and I just realized that my writing instincts overrode the "don't capitalize first letter" that I'd just read. One sec. |
1. Add a shields.io license badge to allow quick, effective identification of the license without requiring the user to scroll to the bottom of the page. 2. Remove the single-word license section at the bottom of the page as it is now superfluous and looks unpolished. 3. Move the crates.io badge beyond the license badge so that its orange colour won't knock the viewer's brain off fast-path evaluation when using the badge row as a status dashboard (as explained in #525). Fixes #525
seanmonstar
added a commit
that referenced
this pull request
Jun 3, 2015
Add a license badge to README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move the crates.io badge beyond the license badge to optimize the badge
row's utility as a status dashboard as discussed in #525.