Add optional serialization of common types via serde.
#603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwalton
force-pushed
the
serde
branch
2 times, most recently
from
e76b590 to
e5f5801
Compare
| @@ -94,4 +99,20 @@ impl ContentType { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "serde-serialization")] | |||
There was a problem hiding this comment.
Everything else looks great, but can we move this into the definition of the header macro, so that we automatically get serialization for most headers?
|
@reem Done. |
| @@ -190,6 +214,8 @@ macro_rules! header { | |||
| self.fmt_header(f) | |||
| } | |||
| } | |||
|
|
|||
| generate_header_serialization!($id); | |||
There was a problem hiding this comment.
Unfortunately this doesn't work without exporting generate_header_serialization too, since the expansion is in another namespace.
We can just export it with a __ prefix like __hyper_deref.
This is behind a Cargo feature to avoid forcing downstream users to depend on `serde`. It is needed for Servo IPC to work.
|
@reem Exported and added the namespace. |
|
Awesome, LGTM. |
reem
added a commit
that referenced
this pull request
Jul 11, 2015
Add optional serialization of common types via `serde`.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jul 18, 2015
compositing: Make the constellation messages serializable. Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6593) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jul 18, 2015
compositing: Make the constellation messages serializable. Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6593) <!-- Reviewable:end -->
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…ializable (from pcwalton:constellation-ipc); r=jdm Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? @jdm Source-Repo: https://github.com/servo/servo Source-Revision: 2f4bdc6ad631dc56b64622e3390943b59270b3ae
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…ializable (from pcwalton:constellation-ipc); r=jdm Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: 2f4bdc6ad631dc56b64622e3390943b59270b3ae UltraBlame original commit: 2564d34df7d27ad820f50ea42fdbb4667faab300
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…ializable (from pcwalton:constellation-ipc); r=jdm Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: 2f4bdc6ad631dc56b64622e3390943b59270b3ae UltraBlame original commit: 2564d34df7d27ad820f50ea42fdbb4667faab300
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…ializable (from pcwalton:constellation-ipc); r=jdm Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: 2f4bdc6ad631dc56b64622e3390943b59270b3ae UltraBlame original commit: 2564d34df7d27ad820f50ea42fdbb4667faab300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is behind a Cargo feature to avoid forcing downstream users to
depend on
serde. It is needed for Servo IPC to work.