Skip to content

Debug #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2014
Merged

Debug #65

merged 3 commits into from
Sep 27, 2014

Conversation

seanmonstar
Copy link
Member

fixes #64

seanmonstar added a commit that referenced this pull request Sep 27, 2014
@seanmonstar seanmonstar merged commit fbd0a41 into master Sep 27, 2014
@@ -71,7 +73,7 @@ impl<L: NetworkListener<S, A>, S: NetworkStream, A: NetworkAcceptor<S>> Server<L
.map(|acceptor| acceptor.move_incoming())
.intertwine();

spawn(proc() {
TaskBuilder::new().named("hyper acceptor").spawn(proc() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this just add a name to failed tasks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it's only used for failures, Yea.
On Sep 27, 2014 3:39 PM, "Jonathan Reem" [email protected] wrote:

In src/server/mod.rs:

@@ -71,7 +73,7 @@ impl<L: NetworkListener<S, A>, S: NetworkStream, A: NetworkAcceptor> Server<L
.map(|acceptor| acceptor.move_incoming())
.intertwine();

  •    spawn(proc() {
    
  •    TaskBuilder::new().named("hyper acceptor").spawn(proc() {
    

Does this just add a name to failed tasks?


Reply to this email directly or view it on GitHub
https://github.com/hyperium/hyper/pull/65/files#r18126235.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, seems reasonable then.

@reem reem deleted the debug branch September 27, 2014 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task '<unknown>' has overflowed its stack
2 participants