Skip to content

Breaks in IE10 #5

Closed
Closed
@jhildenbiddle

Description

@jhildenbiddle

I know IE10 is becoming less relevant with every passing day, but I thought this was worth mentioning since docsify lists IE10 as an officially supported browser.

The error is caused by the use of Object.assign which is not supported by IE10 (line 20 in pagination.js):

let options = Object.assign({}, DEFAULT_OPTIONS, vm.config.

I made a quick fix by replacing the above line with the following:

let options = JSON.parse(JSON.stringify(DEFAULT_OPTIONS));

if (vm.config.pagination) {
  Object.keys(vm.config.pagination).forEach(key => {
    options[key] = vm.config.pagination[key]
  })
}

There are more elegant ways to merge objects, but the above code was intended as a quick test to see if replacing Object.assign would bring IE10 compatibility. The result is that IE10 no longer throws an error, but the page navigation is never rendered.

Usually I would explore more and try to solve the problem, but I am afraid I will be unable to do so for a few more days. Posting the issue here in case someone else wants to take on the task.

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions