This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Added headers parameter to InfluxDBClient #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nathanielatom will take a look and get back to you! |
|
@sebito91 any thoughts or feedback? |
|
@nathanielatom I'm sorry for the extremely late reply, but I think this is a nice PR. Could you please rebase against master and make sure to take the current defaults there? |
sebito91
suggested changes
Apr 10, 2020
|
Sure! :) |
sebito91
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we'd like to use the
DataFrameClientfor writing and querying data from our Influx DB, which is accessible through an API Gateway we have setup. This requires an API key in the header of any requests for authentication.This commit simply adds an optional
headersparameter toInfluxDBClient.__init__. The default is {} and if 'Content-Type' or 'Accept' aren't present they'll be added with the same values as before.Note I also made another very small change in
InfluxDBClient.writewhich I think provides a small bug fix, since previously the 'Content-Type' of theself._headersdict was getting inadvertently modified.