Skip to content

feat(rust/signed-doc): CBOR encoder using minicbor #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: feat/new-cat-signed-doc
Choose a base branch
from

Conversation

no30bit
Copy link
Contributor

@no30bit no30bit commented May 28, 2025

Description

Migrating signed-doc encoding from coset to minicbor.

Related Issue(s)

Closes #332

Description of Changes

  • Refactored the document builder to be more general.
  • Implemented used COSE logic.
  • Refactored ContentType, ContentEncoding and DocumentRef to minicbor.

Breaking Changes

  • serde support removed for signed_doc.
  • ciborium and coset support removed.
  • Builder type is refactored a lot.

Related Pull Requests

#338

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@no30bit no30bit changed the base branch from main to feat/new-cat-signed-doc May 28, 2025 02:54
@no30bit no30bit requested a review from Mr-Leshiy May 28, 2025 02:54
@no30bit no30bit self-assigned this May 28, 2025
@no30bit no30bit added enhancement New feature or request do not review wip labels May 28, 2025
@no30bit no30bit added this to Catalyst May 28, 2025
@no30bit no30bit moved this from New to 🏗 In progress in Catalyst May 28, 2025
@no30bit no30bit added the do not merge yet PR is not ready to merge yet label May 28, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🔖 Ready in Catalyst May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to merge yet do not review enhancement New feature or request wip
Projects
Status: 🔖 Ready
Development

Successfully merging this pull request may close these issues.

Implement true minicbor encoder for catalyst signed documents.
2 participants