Add shell.allDeps as a fix for #1793
#1794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishmack
changed the title
shell.allDeps as a fixshell.allDeps as a fix for #1793
#1769 added all the tool dependencies of the hsPkgs in a project to the shell. This is great for cabal projects where the set of packages will be limited to those in the plan. It allows these packages to be rebuilt by cabal. For stack projects however this set is much larger (all of stackage), likely to include unwanted tools and tools that may be broken. This change adds `shell.allDeps` and defaults it to `false` for stack projects. Fixes #1793
hamishmack
force-pushed
the
hkm/all-tool-deps
branch
from
9b09702 to
310c995
Compare
michaelpj
reviewed
Nov 29, 2022
michaelpj
reviewed
Nov 29, 2022
michaelpj
approved these changes
Nov 29, 2022
|
For stack projects if tools are needed in the shell that are not in the
|
|
bors try |
tryTimed out. |
|
bors try |
tryTimed out. |
|
bors try |
tryTimed out. |
|
This fix worked for the small repo I did to reproduce the problem, but sadly it didn't work for my company's repo. I've added more info on the issue I opened, and hopefully you can pick up on something that I haven't been able to see from days of trying : ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1769 added all the tool dependencies of the hsPkgs in a project to the shell. This is great for cabal projects where the set of packages will be limited to those in the plan. It allows these packages to be rebuilt by cabal.
For stack projects however this set is much larger (all of stackage), likely to include unwanted tools and tools that may be broken.
This change adds
shell.allDepsand defaults it tofalsefor stack projects.Fixes #1793